KEP-5491: DRA: List Types for Attributes #5698
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
everpeace
force-pushed
the
KEP-5491-alpha
branch
16 times, most recently
from
6740a4d to
ff35ed6
Compare
everpeace
force-pushed
the
KEP-5491-alpha
branch
from
ff35ed6 to
e418c60
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everpeace The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
everpeace
left a comment
everpeace
left a comment
There was a problem hiding this comment.
@johnbelamaric @pohly @pravk03 @klueska @liggitt
I drafted a KEP for KEP-5491: DRA: List Types for Attributes. Please take a look and give your feedback!!
| reviewers: | ||
| - "@johnbelamaric" | ||
| - "@klueska" | ||
| - "@pohly" | ||
| - "@pravk03" | ||
| approvers: | ||
| - "@johnbelamaric" # WG-Device-Management | ||
| - "@klueska" # WG-Device-Management | ||
| - "@pohly" # WG-Device-Management | ||
| - "@dom4ha" # SIG-Scheduling | ||
| - "@liggitt" # API Review |
There was a problem hiding this comment.
I'm not sure these reviewers/approvers are ok. I'm wondering if it's too many? more appropriate ones? I'd like to have feedback.
| components: | ||
| - kube-apiserver | ||
| - kube-scheduler |
There was a problem hiding this comment.
If I understood correctly, this KEP does not need to add the feature gate to kubelet. Am I correct?
| #### Story 2 | ||
|
|
||
| T.B.D. |
There was a problem hiding this comment.
I'd like to have more user stories. Please feel free to provide more use cases, particularly the distinctAttribute with the list-type attribute use case.
| - Redesigning the entire DRA matching model. | ||
| - Currently `Allocator`'s algorithm assumes [_monotonic_ constraints](https://github.com/kubernetes/kubernetes/blob/v1.34.2/staging/src/k8s.io/dynamic-resource-allocation/structured/internal/experimental/allocator_experimental.go#L274-L276) only. Monotonic means that once a constraint returns false, adding more devices will never cause it to return true. This allows to bound the computational complexity for searching device combinations which satisfies the specified constraints. This KEP does NOT intend to change this design. Thus, this KEP focuses to propose monotonic constraints only. |
There was a problem hiding this comment.
This is an important Non-Goal of this KEP. Adding a non-monotonic predicate introduces the risk of increasing the search complexity to an exponential level and would need a large rewrite of the Allocator implementation. So, this KEP only focuses on adding monotonic constraints. Focusing only on monotonic constraints also helps the implementation changes as little as possible as discribed Implementation section in the KEP.
2 participants
/wg device-management
/sig scheduling